Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds glueJob and crawlerName to GlueTransform stage properties #266

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

malachi-constant
Copy link
Contributor

  • Adds glueJob and crawlerName to GlueTransform stage properties

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant self-assigned this Feb 28, 2023
@malachi-constant malachi-constant changed the base branch from main to typescript-conversion February 28, 2023 04:53
Copy link
Collaborator

@anmolsgandhi anmolsgandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the crawler object similarly to the glue job object and not the crawler name as return property. We can return the crawler instead of crawler.ref

@malachi-constant
Copy link
Contributor Author

malachi-constant commented Feb 28, 2023

We need the crawler object similarly to the glue job object and not the crawler name as return property. We can return the crawler instead of crawler.ref

@anmolsgandhi In our current version self._crawler is set to None when crawler_name is specified. Do you think we should continue this behavior? Or find a way to import and return?

@anmolsgandhi
Copy link
Collaborator

We need the crawler object similarly to the glue job object and not the crawler name as return property. We can return the crawler instead of crawler.ref

@anmolsgandhi In our current version self._crawler is set to None when crawler_name is specified. Do you think we should continue this behavior? Or find a way to import and return?

Unlike other cdk constructs, Crawler doesn't have an interface that can import crawler through crawler_name or arn. I think when we create the crawler as part of the stage, it will not possible for the devs to it as that object is not exposed. If the user is passing a crawler name, i am not sure if they will be interesting in either the crawler object or the name as they already would have both the information which is not true when we create the crawler in the stage.

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: e959c77
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 18ca06d into typescript-conversion Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: syncing GlueTransformStage to main
2 participants