Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Configurator() resource id refactor #286

Merged

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Mar 27, 2023

Enhancement

  • Updates Configurator() functionality to update resources with paths matching specified ${id}/Resource
  • User will need to provide a subpath that matches a given resource's cdk metadata path but will not need to specify /Resource as this would override resource's that are created in addition to primary resources (e.g. Default Iam Policies, Event Sources etc)

An id of Process Function would match the following pattern and not the others.
Screen Shot 2023-03-27 at 3 29 08 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 79d0b77
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 52fd47b into typescript-conversion Mar 27, 2023
@malachi-constant malachi-constant deleted the chore/configurator-id-path-refactor branch March 27, 2023 23:01
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: dd90503
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants