Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configurator missing legacy ddk bootstrap values #319

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented May 4, 2023

Fix

  • Configurator missing legacy ddk bootstrap values

Detail

  • update default for file_assets_bucket_name
  • update default for stack_version_ssm_parameter

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant added bug Something isn't working core typescript labels May 4, 2023
@malachi-constant malachi-constant added this to the 1.0.0 milestone May 4, 2023
@malachi-constant malachi-constant self-assigned this May 4, 2023
@malachi-constant malachi-constant added this to In Review in Roadmap May 4, 2023
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 5c2ea1d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 8dce3c8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 300f0fc into typescript-conversion May 4, 2023
5 of 6 checks passed
@malachi-constant malachi-constant deleted the fix/configurator-missing-ddk-legacy-bootstrap-values branch May 4, 2023 19:34
@malachi-constant malachi-constant moved this from In Review to Done in Roadmap May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core typescript
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants