Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update StateMachineStage to use definitionBody instead of deprecated definition #372

Merged
merged 2 commits into from
Jun 30, 2023
Merged

feat: Update StateMachineStage to use definitionBody instead of deprecated definition #372

merged 2 commits into from
Jun 30, 2023

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Jun 29, 2023 •
edited

Changes

Allows for defining of SFN in three ways

  1. definition : stepfunction.IChainable
  2. definition : string JSON
  3. definitionFile : string Path to JSON file

These parameters are now conditionally optional meaning typescript would not allow for them to precede props in createStateMachine(). I think the best approach is to bring the parameters into the StateMachineStageProps interface.

#69

@malachi-constant malachi-constant self-assigned this Jun 29, 2023
@malachi-constant malachi-constant marked this pull request as draft June 29, 2023 22:53
@malachi-constant malachi-constant added enhancement New feature or request core labels Jun 29, 2023
@malachi-constant malachi-constant added this to the 1.1.0 milestone Jun 29, 2023
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: a17508e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant added this to In Progress in Roadmap Jun 30, 2023
@malachi-constant malachi-constant moved this from In Progress to In Review in Roadmap Jun 30, 2023
@malachi-constant malachi-constant marked this pull request as ready for review June 30, 2023 01:31
@malachi-constant malachi-constant linked an issue Jun 30, 2023 that may be closed by this pull request
(core) sfn factory - add json definition #69
Closed
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 1f05515
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

anmolsgandhi
anmolsgandhi approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@anmolsgandhi anmolsgandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its great, we can support all the different patterns!

@malachi-constant malachi-constant merged commit b0107df into main Jun 30, 2023
8 checks passed
@malachi-constant malachi-constant deleted the feat/statemachine-json branch June 30, 2023 18:14
@malachi-constant malachi-constant moved this from In Review to Done in Roadmap Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolsgandhi anmolsgandhi anmolsgandhi approved these changes

@kukushking kukushking Awaiting requested review from kukushking

@jaidisido jaidisido Awaiting requested review from jaidisido

Assignees

@malachi-constant malachi-constant

Labels
core enhancement New feature or request
Projects
Roadmap
Done
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

(core) sfn factory - add json definition
2 participants
@malachi-constant @anmolsgandhi