Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding clearer exception for invalid config #464

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat: Adding clearer exception for invalid config #464

merged 2 commits into from
Nov 15, 2023

Conversation

malachi-constant
Copy link
Contributor

Closes #462

Changes

  • Adding clearer exception for invalid config
  • Restructuring mock config files in testing

@malachi-constant malachi-constant added the enhancement New feature or request label Nov 15, 2023
@malachi-constant malachi-constant self-assigned this Nov 15, 2023
@malachi-constant malachi-constant linked an issue Nov 15, 2023 that may be closed by this pull request
Throw Exception for Invalid JSON Config Files #462
Closed
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 45859dd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 3a5ebf8 into main Nov 15, 2023
5 checks passed
@malachi-constant malachi-constant deleted the 462-throw-exception-for-invalid-json-config-files branch November 15, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@anmolsgandhi anmolsgandhi Awaiting requested review from anmolsgandhi

Assignees

@malachi-constant malachi-constant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw Exception for Invalid JSON Config Files
2 participants
@malachi-constant @LeonLuttenberger