Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(core) adding escape hatches for sqs_lambda stage #47

Merged
merged 5 commits into from
Mar 10, 2022
Merged

(core) adding escape hatches for sqs_lambda stage #47

merged 5 commits into from
Mar 10, 2022

Conversation

malachi-constant
Copy link
Contributor

Feature

  • Adding escape hatch for aws_ddk_core.stages.SqsToLambdaStage

Detail

  • Add arguments to aws_ddk_core.stages.SqsToLambdaStage
    • lambda_function: Optional[IFunction]
      Preexisting Lambda Function to use in stage. None by default
    • sqs_queue: Optional[IQueue]
      Preexisting SQS Queue to use in stage. None by default
  • Unit tests to validate the above arguments.
    • test_sqs_lambda_stage.py::test_sqs_lambda_with_existing_function
    • test_sqs_lambda_stage.py::test_sqs_lambda_with_existing_queue

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant added enhancement New feature or request core labels Mar 9, 2022
@malachi-constant malachi-constant added this to the 0.2.0 milestone Mar 9, 2022
@malachi-constant malachi-constant linked an issue Mar 9, 2022 that may be closed by this pull request
(core) add escape hatches for relevant ddk stages #46
Closed
@malachi-constant malachi-constant self-assigned this Mar 9, 2022
jaidisido
jaidisido previously requested changes Mar 9, 2022
View reviewed changes
core/aws_ddk_core/stages/sqs_lambda.py Show resolved Hide resolved
core/aws_ddk_core/stages/sqs_lambda.py Outdated Show resolved Hide resolved
@malachi-constant malachi-constant merged commit 6c046c2 into main Mar 10, 2022
@jaidisido jaidisido deleted the 46-(core)-add-escape-hatches-for-relevant-ddk-stages branch March 11, 2022 12:31
@malachi-constant malachi-constant added this to Done in Roadmap Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido Awaiting requested review from jaidisido

Assignees

@malachi-constant malachi-constant

Labels
core enhancement New feature or request
Projects
Roadmap
Done
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

(core) add escape hatches for relevant ddk stages
3 participants
@malachi-constant @kukushking @jaidisido