(core) add appflow stage #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnfait
force-pushed
the
appflow-stage
branch
2 times, most recently
from
766792d
to
6c436c7
Compare
cnfait
force-pushed
the
appflow-stage
branch
6 times, most recently
from
41f5c53
to
4fe4ee9
Compare
kukushking
reviewed
Mar 31, 2022
kukushking
reviewed
Mar 31, 2022
kukushking
approved these changes
Mar 31, 2022
kukushking
reviewed
Mar 31, 2022
core/aws_ddk_core/stages/appflow.py
Outdated
| ) | ||
|
|
||
| # Create start flow step function task | ||
| flow_object = CustomState( |
There was a problem hiding this comment.
One idea is to make the constructor shorter and more readable perhaps we should move some code into private methods e.g. _create_start_flow_custom_task(flow_name: str, ...), etc.
There was a problem hiding this comment.
I've done this for the custom state task and the lambda task!
There was a problem hiding this comment.
Do you need the variables like flow_object in _create_start_flow_custom_task? I think you can just return CustomState(...)
kukushking
reviewed
Mar 31, 2022
jaidisido
reviewed
Mar 31, 2022
cnfait
force-pushed
the
appflow-stage
branch
2 times, most recently
from
06d8052
to
7548e9c
Compare
jaidisido
reviewed
Mar 31, 2022
core/aws_ddk_core/stages/lambda_handlers/appflow_check_flow_status/index.py
Outdated
Show resolved
Hide resolved
cnfait
force-pushed
the
appflow-stage
branch
3 times, most recently
from
09266f6
to
66bcc72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.