(core) add firehose delivery ingestion stage #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukushking
reviewed
Mar 31, 2022
kukushking
reviewed
Mar 31, 2022
kukushking
reviewed
Mar 31, 2022
jaidisido
reviewed
Apr 1, 2022
…rehose-delivery-ingestion-stage
kukushking
reviewed
Apr 4, 2022
|
|
||
| This construct allows to configure parameters of the firehose delivery stream using ddk.json | ||
| configuration file depending on the `environment_id` in which the function is used. | ||
| Supported parameters are: |
There was a problem hiding this comment.
Minor - missing supported params
kukushking
reviewed
Apr 4, 2022
| elif data_stream: | ||
| self._data_stream = data_stream | ||
| else: | ||
| self._data_stream = None |
There was a problem hiding this comment.
Minor - I guess you can just leave else: self._data_stream = data_stream
kukushking
reviewed
Apr 4, 2022
kukushking
approved these changes
Apr 4, 2022
kukushking
reviewed
Apr 4, 2022
jaidisido
requested changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Detail
FirehoseFactory()Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.