(docs) expose configuration attributes for classes in documentation #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the Config concept for DDK deserves its own docs page explaining property precedence in resource factory classes in more detail? I've left out updating any resource factory docstrings as it would be redundant with |
jaidisido
reviewed
Apr 14, 2022
There was a problem hiding this comment.
I can't think of another way to document these.
To clarify for the user, I suggest:
- Adding a How-To guide explaining how our configuration works in general in the DDK
- Reference this How-To under the
Supported DDK Environment Configurationline here
What do you think?
kukushking
approved these changes
Apr 14, 2022
|
How-to guide to be added: #98 |
…-configuration-attributes-for-classes-in-documentation
jaidisido
deleted the
88-docs-expose-configuration-attributes-for-classes-in-documentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds documentation of available configuration attributes to
BaseStackandCICDPipelineStackclasses.Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.