-
Notifications
You must be signed in to change notification settings - Fork 225
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Feat: Improve samples
**Why?**
These changes aim to improve the overall quality, maintainability, and
usability of the ADF sample templates, while also providing better
documentation and aligning with the latest AWS best practices.
- To adhere to best practices and improve maintainability of the code base.
- To enhance security and observability by enabling VPC Flow Logs.
- To address code style issues and enforce consistent formatting.
**What?**
- Specified explicit files to include in the CodeBuild output artifacts.
- Improvements to the VPC example:
- Added support for enabling VPC Flow Logs to S3 or CloudWatch Logs.
- Refactored resource ordering and added conditions for better readability.
- Exported additional VPC CIDR range output for convenience.
- Fixed minor documentation issues in sample guides.
- Update README files with additional details, prerequisites, and deployment
instructions for various samples.
- Upgrade the `sample-fargate-node-app` to use the AWS public container registry
(public.ecr.aws) instead.
- Refactor the `sample-ec2-with-codedeploy` sample to use AWS Launch Templates,
a newer and recommended approach instead of Launch Configurations.
- Update `sample-ec2-with-codedeploy` scripts to install newer versions of
Amazon Linux 2023, Java, and other dependencies. Also fixed the scripts to be
compatible to the recommended IMDSv2 authenticated APIs.
- Miscellaneous improvements and bug fixes across various sample templates.
---
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.
* Fix markdown table in changelog- Loading branch information
Showing
47 changed files
with
1,034 additions
and
457 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Sample CDK Bootstrap pipeline | ||
|
|
||
| This pipeline is expecting *(in the example case)* an AWS CodeCommit repository | ||
| on the account `111111111111` in your main deployment region named | ||
| *sample-cdk-bootstrap*. | ||
|
|
||
| ## Deployment Map example | ||
|
|
||
| ```yaml | ||
| - name: sample-cdk-bootstrap | ||
| default_providers: | ||
| source: | ||
| provider: codecommit | ||
| properties: | ||
| account_id: 111111111111 | ||
| build: | ||
| provider: codebuild | ||
| properties: | ||
| image: "STANDARD_7_0" | ||
| targets: | ||
| - /banking/testing | ||
| - /banking/production | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Copyright Amazon.com Inc. or its affiliates. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| version: 0.2 | ||
|
|
||
| phases: | ||
| install: | ||
| runtime-versions: | ||
| python: 3.12 | ||
| nodejs: 20 | ||
| commands: | ||
| - aws s3 cp s3://$S3_BUCKET_NAME/adf-build/ adf-build/ --recursive --quiet | ||
| - pip install -r adf-build/requirements.txt -q | ||
| - python adf-build/generate_params.py | ||
|
|
||
| build: | ||
| commands: | ||
| - npm install aws-cdk -g | ||
| - cdk bootstrap --show-template > template.yml | ||
|
|
||
| artifacts: | ||
| files: '**/*' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # Copyright Amazon.com Inc. or its affiliates. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Parameters of the CDK Bootstrap stack: | ||
| # TrustedAccounts: | ||
| # Description: List of AWS accounts that are trusted to publish assets and deploy stacks to this environment | ||
| # Default: "" | ||
| # Type: CommaDelimitedList | ||
| # TrustedAccountsForLookup: | ||
| # Description: List of AWS accounts that are trusted to look up values in this environment | ||
| # Default: "" | ||
| # Type: CommaDelimitedList | ||
| # CloudFormationExecutionPolicies: | ||
| # Description: List of the ManagedPolicy ARN(s) to attach to the CloudFormation deployment role | ||
| # Default: "" | ||
| # Type: CommaDelimitedList | ||
| # FileAssetsBucketName: | ||
| # Description: The name of the S3 bucket used for file assets | ||
| # Default: "" | ||
| # Type: String | ||
| # FileAssetsBucketKmsKeyId: | ||
| # Description: Empty to create a new key (default), 'AWS_MANAGED_KEY' to use a managed S3 key, or the ID/ARN of an existing key. | ||
| # Default: "" | ||
| # Type: String | ||
| # ContainerAssetsRepositoryName: | ||
| # Description: A user-provided custom name to use for the container assets ECR repository | ||
| # Default: "" | ||
| # Type: String | ||
| # Qualifier: | ||
| # Description: An identifier to distinguish multiple bootstrap stacks in the same environment | ||
| # Default: hnb659fds | ||
| # Type: String | ||
| # AllowedPattern: "[A-Za-z0-9_-]{1,10}" | ||
| # ConstraintDescription: Qualifier must be an alphanumeric identifier of at most 10 characters | ||
| # PublicAccessBlockConfiguration: | ||
| # Description: Whether or not to enable S3 Staging Bucket Public Access Block Configuration | ||
| # Default: "true" | ||
| # Type: String | ||
| # AllowedValues: | ||
| # - "true" | ||
| # - "false" | ||
| # InputPermissionsBoundary: | ||
| # Description: Whether or not to use either the CDK supplied or custom permissions boundary | ||
| # Default: "" | ||
| # Type: String | ||
| # UseExamplePermissionsBoundary: | ||
| # Default: "false" | ||
| # AllowedValues: | ||
| # - "true" | ||
| # - "false" | ||
| # Type: String | ||
| # BootstrapVariant: | ||
| # Type: String | ||
| # Default: "AWS CDK: Default Resources" | ||
|
|
||
| Parameters: | ||
| TrustedAccounts: 'resolve:/adf/deployment_account_id' | ||
| TrustedAccountsForLookup: 'resolve:/adf/deployment_account_id' | ||
|
|
||
| Tags: | ||
| Repository: sample-codebuild-vpc-repo | ||
| App: Sample CodeBuild VPC application |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.