Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading between version should not make changes to global.yml #85

Closed
bundyfx opened this issue Jul 1, 2019 · 1 comment · Fixed by #107
Closed

Upgrading between version should not make changes to global.yml #85

bundyfx opened this issue Jul 1, 2019 · 1 comment · Fixed by #107
Labels
enhancement New feature or request
Milestone
1.2.1

Comments

@bundyfx
Copy link
Contributor

bundyfx commented Jul 1, 2019

When making the PR with the new content for ADF we should ignore global.yml in the root of the repository.
@bundyfx bundyfx added the enhancement New feature or request label Jul 1, 2019
@bundyfx bundyfx added this to the 1.2.0 milestone Jul 4, 2019
@thiezn
Copy link
Contributor

thiezn commented Jul 5, 2019

Hi @bundyfx,

We've not only been updating the global.yml in the root folder of the bootstrap repository. We've also made changes to the deployment/global.yml and deployment/regional.yml to allow our codebuild stage to do things in the master account for the Organizational and FMS api's.

Perhaps all the global.yml's can be renamed to global-example.yml to avoid overwriting any customer customization.

Cheers,
Thiezn

@bundyfx bundyfx modified the milestones: 1.2.0, 1.3.0, 1.2.1 Jul 22, 2019
@bundyfx bundyfx mentioned this issue Jul 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

v1.2.1 bundyfx/aws-deployment-framework
2 participants
@thiezn @bundyfx