Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup of parameters upon pipeline retirement #652

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix cleanup of parameters upon pipeline retirement #652

merged 1 commit into from
Aug 9, 2023

Commits on Aug 8, 2023

  1. Fix cleanup of parameters upon pipeline retirement 

    **Why?**

At the moment, the pipeline deletion process attempts to delete the parameters
at `/deployment/${pipeline_name}/regions`. However, the path it should use
needs to include the source of the pipeline definition. In this case, that is
`S3`. So it should have deleted: `/deployment/S3/${pipeline_name}/regions`.

Additionally, if the parameter is not found, it would mark that as a failure.
While there is nothing to delete if it isn't found, so it should accept that
instead.

**What?**

Fixed path and added a catch to make the ParameterNotFound exception pass
anyway.
    @sbkok @StewartW
    sbkok authored and StewartW committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    51ab951 View commit details
    Browse the repository at this point in the history