Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing deployment_account_id and initial deployment global IAM bootstrap #686

Closed

Commits on Jan 18, 2024

  1. Fix missing deployment_account_id and initial deployment global IAM b…

    …ootstrap
    
    **Why?**
    
    Issues: awslabs#659 and awslabs#594.
    
    When installing ADF the first time, the global IAM bootstrap stack that gets
    deployed is sourced from the `adf-bootstrap/global-iam.yml`.
    
    The reason for this behaviour is the absence of the `global-iam.yml` file
    in the deployment OU bootstrap folder
    (`adf-bootstrap/deployment/global-iam.yml`).
    
    It iterates to the parent directory until it finds a `global-iam.yml` to
    deploy. Hence, when the `adf-bootstrap/global-iam.yml` gets deployed in the
    deployment account, it was looking for the `deployment_account_id` SSM
    parameter. That did not get deployed in the deployment account.
    
    **What?**
    
    * Add the creation of the `deployment_account_id` in the deployment account,
      so if the global IAM bootstrap stack failed to deploy before, it will work
      in the next release. This would be the case if the previous deployment failed
      but the same `aws-deployment-framework-bootstrap` repository is used in the
      upgrade.
    * When installing the first time, it creates the bootstrap repository.
      At the time of creation, it will copy the
      `adf-bootstrap/deployment/example-global-iam.yml` to
      `adf-bootstrap/deployment/global-iam.yml`.
      The same logic as how ADF creates the initial `adf-bootstrap/global-iam.yml`.
    sbkok committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2a1b825 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    ee59a90 View commit details
    Browse the repository at this point in the history
  2. Ensure tox fails at first pytest failure

    **Why?**
    
    At the moment, pytest failures were ignored due to a change in the Makefile
    used to execute tests. The ADF CI GitHub Workflow would result in a
    success, even when a test case failed.
    
    **What?**
    
    Fixed by exiting on the first failure using Makefile foreach instead.
    sbkok committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    93d65ef View commit details
    Browse the repository at this point in the history