Fix memory leak with passing in TLS context config from php application #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this bug is present upstream, would you submit the PR to php-memcached-dev/php-memcached |
|
This is specific to the AWS extension that adds TLS support to Elasticache:Memcache. |
barshaul
approved these changes
Mar 19, 2024
| ok = 0; | ||
| } | ||
| return ok; | ||
| } | ||
|
|
||
| static void php_free_tls_context_configurations(memcached_ssl_context_config *config) { | ||
| if (config->cert_file) { |
There was a problem hiding this comment.
minor: indentation is off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
createAndSetTLSContextimproperly handled zend_string reference counting and didn't free memory after the context was set. Fix by simplifying the hash loop by immediately callingphp_set_tls_context_configurationswith the zkey and zvalue. We then let the conversion of the zvalue type happen for the specific config setting. Also, add helper method to strdup values using the proper zval_string and release methods.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.