Add support for high-resolution metrics in EMF #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshwa19
reviewed
Jan 11, 2023
meshwa19
reviewed
Jan 11, 2023
meshwa19
reviewed
Jan 11, 2023
meshwa19
reviewed
Jan 11, 2023
tests/Amazon.CloudWatch.EMF.Tests/Model/MetricDefinitionTests.cs
Outdated
Show resolved
Hide resolved
meshwa19
reviewed
Jan 11, 2023
tests/Amazon.CloudWatch.EMF.Tests/Model/MetricDirectiveTests.cs
Outdated
Show resolved
Hide resolved
meshwa19
reviewed
Jan 11, 2023
meshwa19
reviewed
Jan 11, 2023
meshwa19
reviewed
Jan 11, 2023
meshwa19
reviewed
Jan 11, 2023
tests/Amazon.CloudWatch.EMF.IntegrationTests/MetricsLoggerIntegrationTest.cs
Outdated
Show resolved
Hide resolved
meshwa19
approved these changes
Jan 13, 2023
|
nit: run |
markkuhn
reviewed
Jan 13, 2023
|
markkuhn
reviewed
Jan 19, 2023
Co-authored-by: Mark Kuhn <kuhn.mark@outlook.com>
markkuhn
reviewed
Jan 19, 2023
Co-authored-by: Mark Kuhn <kuhn.mark@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added support for High Resolution Metrics. Customers can specify an optional property - storageResolution of the metrics in putMetric() call. If resolution is not specified, metrics will be emitted with standard resolution.
Covered Unit Test methods.
Updated README.md and examples folder.
Updated the canary. See the image below for Memory.VirtualMemorySize64 Memory usage. (Note: We will have to wait until the feature is enabled to get metrics in high resolution for the canary)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.