Used gradle to init the project and package #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcnance
approved these changes
Jul 10, 2020
build.gradle
Outdated
|
|
||
| dependencies { | ||
| // This dependency is exported to consumers, that is to say found on their compile classpath. | ||
| api 'org.apache.commons:commons-math3:3.6.1' |
There was a problem hiding this comment.
I'm assuming we don't need this and was just the gradle default?
There was a problem hiding this comment.
Yes. It was auto-generated. I didn't change that as all the code was generated and was planning to remove it later. But I can do it now.
| .idea | ||
| *.iml | ||
| .settings | ||
|
|
There was a problem hiding this comment.
There is a gradle-wrapper.jar below, I think we need *.jar here?
There was a problem hiding this comment.
The gradle-wrapper.jar is needed as it can help other developers to build the project without having Gradle installed on their machine.
settings.gradle
Outdated
| * in the user manual at https://docs.gradle.org/6.5.1/userguide/multi_project_builds.html | ||
| */ | ||
|
|
||
| rootProject.name = 'aws-embedded-metrics-java' |
There was a problem hiding this comment.
While the repo name is *-java, for classpathing and package naming we should drop the java suffix.
Stephen-Bao
added a commit
that referenced
this pull request
Aug 18, 2022
Code changes and unit tests for thread-safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Run
gradle initto initialize the project.Project Name: aws-embedded-metrics-java
Package Name: software.amazon.awssdk.services.cloudwatchlogs.emf
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.