Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High Resolution Metrics Support #129

Merged
merged 21 commits into from
Jan 23, 2023
Merged

High Resolution Metrics Support #129

merged 21 commits into from
Jan 23, 2023

Conversation

meshwa19
Copy link
Contributor

@meshwa19 meshwa19 commented Dec 19, 2022 •
edited
Loading

Description of changes:

  • Added support for High Resolution Metrics. Customers can specify an optional property - storageResolution of the metrics in putMetric() call. If resolution is not specified, metrics will be emitted with standard resolution.
  • Added UTs and modified integration tests for the changes.
  • Updated README.md and examples folder.
  • Updated the canary. See the image below for memory usage. (Note: We will have to wait until the feature is enabled to get metrics in high resolution for the canary)

Screen Shot 2022-12-21 at 3 47 58 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@meshwa19 meshwa19 force-pushed the feature/high-resolution-metrics branch from 709e68a to 159f82e Compare December 19, 2022 15:58
markkuhn
markkuhn reviewed Dec 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@meshwa19 meshwa19 requested review from rayabagi and markkuhn and removed request for rayabagi December 21, 2022 23:57
@meshwa19 meshwa19 force-pushed the feature/high-resolution-metrics branch from 1af2ca4 to ab11455 Compare January 3, 2023 18:35
markkuhn
markkuhn approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@markkuhn markkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

markkuhn
markkuhn reviewed Jan 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@markkuhn markkuhn added the enhancement New feature or request label Jan 13, 2023
@meshwa19 @markkuhn
Update README.md
cfb9b1e 
Co-authored-by: Mark Kuhn <kuhn.mark@outlook.com>
@meshwa19 meshwa19 merged commit c404b63 into awslabs:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markkuhn markkuhn markkuhn approved these changes

@giancarlokc giancarlokc giancarlokc approved these changes

@rayabagi rayabagi rayabagi approved these changes

Assignees

@meshwa19 meshwa19

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@meshwa19 @giancarlokc @markkuhn @rayabagi