Add asynchronous flush support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcnance
commented
Jul 27, 2021
jaredcnance
changed the title
jaredcnance
force-pushed
the
jared/add-async-flushing
branch
from
0693e3d
to
864a93a
Compare
jaredcnance
commented
Jul 27, 2021
src/main/java/software/amazon/cloudwatchlogs/emf/sinks/AgentSink.java
Outdated
Show resolved
Hide resolved
jaredcnance
commented
Jul 27, 2021
src/main/java/software/amazon/cloudwatchlogs/emf/sinks/AgentSink.java
Outdated
Show resolved
Hide resolved
jaredcnance
commented
Jul 27, 2021
src/main/java/software/amazon/cloudwatchlogs/emf/sinks/ISink.java
Outdated
Show resolved
Hide resolved
jaredcnance
force-pushed
the
jared/add-async-flushing
branch
5 times, most recently
from
9a934b4
to
f7533b8
Compare
jaredcnance
commented
Jul 30, 2021
| SocketClientFactory clientFactory) { | ||
| SocketClientFactory clientFactory, | ||
| int asyncQueueDepth, | ||
| Supplier<RetryStrategy> retryStrategy) { |
jaredcnance
commented
Jul 30, 2021
| * @return a future that completes when the shutdown has completed successfully and all pending | ||
| * messages have been sent to the destination. | ||
| */ | ||
| CompletableFuture<Void> shutdown(); |
jaredcnance
commented
Jul 30, 2021
jaredcnance
force-pushed
the
jared/add-async-flushing
branch
from
f7533b8
to
8cd1bc8
Compare
jaredcnance
commented
Jul 31, 2021
jaredcnance
force-pushed
the
jared/add-async-flushing
branch
from
e1e09a4
to
8cd1bc8
Compare
yaozhaoy
reviewed
Aug 4, 2021
|
|
||
| /** | ||
| * The max number of messages to hold in memory in case of transient socket errors. The maximum | ||
| * message size is 256 KB meaning the maximum size of this buffer would be 25,600 MB |
yaozhaoy
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds asynchronous flushing, automatic retries for transient socket errors, and graceful shutdown.
Design Notes / Other Considerations:
AgentSink.CompletableFuture. An alternative to this is providing an(long timeout, TimeUnit unit)signature similar toawaitTerminationwhich would allow us to use that interface directly when shutting down the executor. However, this creates an awkward API that doesn't easily support composition with other tasks to run in parallel.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.