Skip empty batches #125
Merged
Skip empty batches #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AKoetsier , Thank you so much. I've never realized this issue and the way to fix it is awesome. I'll release this merge in the next v1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ValidationException is thrown by Kinesis when fluentd receives log messages that are all more than 1MB in size. The reason is that all messages will be skipped and an empty batch is send to Kinesis which will throw the validation exception. This will cause the batch to fail and all messages will stay in the buffer causing it to fill up. This patch will skip any empty batches.