make sleep reliable by measuring how long we actually slept #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
force-pushed
the
grosser/sleep
branch
2 times, most recently
from
21710fb
to
f027e5b
Compare
|
test failure seems unrelated |
grosser
force-pushed
the
grosser/sleep
branch
from
f027e5b
to
e9993fb
Compare
|
Hi, Thank you for your commit. As your comment in the code, is it still unreliable even if we merge this commit? Also, did you look into how AWS SDK for Ruby handle similar situation? |
|
it is reliable with this commit, I did not find any other part where this happens ... this is all pretty old now and we have migrated away from fluentd in the last month, so I can't test/reproduce this anymore |
|
Got it. Thank you for your reply. |
|
Closing this PR for now. Please reopen if required. Thank you! |
|
Reopened to make test this more reliable sleep along with enhancement of batch request monitoring. |
simukappu
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adammw @riywo
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.