Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gzip compression #215

Merged
merged 4 commits into from
Nov 14, 2021
Merged

Add support for gzip compression #215

merged 4 commits into from
Nov 14, 2021

Conversation

ODudek
Copy link
Contributor

@ODudek ODudek commented Oct 25, 2021

Issue #, if available:

Description of changes:

Send data to kinesis using gzip compression

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ODudek ODudek changed the title add support for gzip compression Add support for gzip compression Oct 25, 2021
Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should handle adding feature and version upgrade separately. Can you remove version upgrade to 3.4.2 from your PR? The gzip compression feature you added looks good. Thank you for your contribution!

CHANGELOG.md Outdated Show resolved Hide resolved
lib/fluent_plugin_kinesis/version.rb Outdated Show resolved Hide resolved
@ODudek ODudek requested a review from simukappu November 8, 2021 10:18
Copy link
Contributor

@simukappu simukappu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simukappu simukappu merged commit f309128 into awslabs:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants