Add CMake Versioning Module #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewpaul
requested review from
lwilkovich,
fufranci,
HarshGandhi-AWS and
giordzaws
matthewpaul
force-pushed
the
semanticVersioning
branch
from
7edb51e
to
81055ea
Compare
giordzaws
reviewed
Dec 11, 2020
giordzaws
reviewed
Dec 11, 2020
giordzaws
reviewed
Dec 11, 2020
matthewpaul
force-pushed
the
semanticVersioning
branch
from
65d4baa
to
172d3bd
Compare
added 7 commits
December 14, 2020 12:24
With this commit, I have added automated versioning support via CMake that will provide Semantic Versioning for the Device Client executable. I have also included instructions for how to tag elements of this package's repository with version information that will automatically get built into the executable for debugging and tracking purposes.
With this commit, I added a bit to the git version tag glob so that we try to at least match numbers rather than just anything starting with a v. Also fixed a merge issue that was running the same src glob twice.
Fixing some files that are causing the linter to fail
Attempting to modify our ci.yml file to make github actions pull the tag information when checking out the current branch.
Added the command to pull all tags for all workflow steps.
Fixed an issue with the fetch-depth that was improperly formatted.
Github actions was unable to parse my updated ci.yml file due to some indentation issues.
matthewpaul
force-pushed
the
semanticVersioning
branch
from
0988ca6
to
ed668fc
Compare
Formatting was done in the wrong direction on last commit
Fix formatting for ci.yml
Attempting to help github actions resolve versioning issue
fufranci
reviewed
Dec 15, 2020
Comment on lines
+187
to
+192
| LOGM_INFO( | ||
| TAG, | ||
| "Now running AWS IoT Device Client version v%d.%d.%d", | ||
| DEVICE_CLIENT_VERSION_MAJOR, | ||
| DEVICE_CLIENT_VERSION_MINOR, | ||
| DEVICE_CLIENT_VERSION_PATCH); |
There was a problem hiding this comment.
This is probably outside the scope of this PR. But we could add a Cli option such as --version. The Cli parsing logic can take a lambda and you can send this information to cout just like how we print --help.
There was a problem hiding this comment.
That's a really good idea! I can add it in a follow up CR
lwilkovich
approved these changes
Dec 15, 2020
giordzaws
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, I have added automated versioning support via CMake that will provide Semantic Versioning for the Device Client executable. I have also included instructions for how to tag elements of this package's repository with version information that will automatically get built into the executable for debugging and tracking purposes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.