Skip to content

Commit

Permalink
Merge pull request #8 from heuermh/patch-1
Browse files Browse the repository at this point in the history
Minor typo, fix StandardOpenOption.READ to StandardOpenOption.WRITE
  • Loading branch information
markjschreiber committed Mar 22, 2023
2 parents 9439036 + c7b5dd7 commit e449c6c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ Ensure sufficient memory is available to your JVM if you increase the fragment s
## Writing Files

The mode of the channel is controlled with the `StandardOpenOptions`. To open a channel for write access you need to
supply the option `StandardOpenOption.READ`. All write operations on the channel will be gathered in a temporary file,
supply the option `StandardOpenOption.WRITE`. All write operations on the channel will be gathered in a temporary file,
which will be uploaded to S3 upon closing the channel.

Be aware, that the current implementation only supports channels to be used either for read or write due to potential
Expand Down Expand Up @@ -267,4 +267,4 @@ We use JUnit 4 and Mockito for unit testing.

When contributing code for bug fixes or feature improvements, matching tests should also be provided. Tests must not
rely on specific S3 bucket access or credentials. To this end, S3 clients and other artifacts should be mocked as
necessary. Remember, you are testing this library, not the behavior of S3.
necessary. Remember, you are testing this library, not the behavior of S3.

0 comments on commit e449c6c

Please sign in to comment.