Add FORCE_PATH_STYLE into the defaults of S3NioSpiConfiguration in order to allow it to be modified via environment variables
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markjschreiber just a small change, that would help us immensely |
markjschreiber
requested changes
May 27, 2024
…order to allow it to be modified via environment variables
oeph
force-pushed
the
feature/add_path_style_access_into_defaults
branch
from
402fa0c
to
1cab067
Compare
Shortens line to make checkstyle happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the "auto-create" of the file systems, we experience cases, where we cannot set the FORCE_PATH_STYLE method to
true.Description of changes:
By adding the
s3.spi.force-path-styleoption to the defaults, it will get picked up by the default handling and can be modified via environment variables. The default is set tofalse.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.