Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cypress (v9 to v12), vite (v2 to v4) #134

Merged
merged 3 commits into from
Aug 14, 2023
Merged

update cypress (v9 to v12), vite (v2 to v4) #134

merged 3 commits into from
Aug 14, 2023

Conversation

hakanson
Copy link
Contributor

Issue #, if available: n/a

Description of changes:

  • major version update of vite from 2.9.6 to 4.4.9
  • major version update of cypress from 9.5.2 to 12.17.3; required migration of config and tests to new format
  • run-tests.sh required port updates for vite; existing kill/wait logic wasn't working on local

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ottokruse
ottokruse approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@ottokruse ottokruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ottokruse ottokruse merged commit 2c37cec into awslabs:main Aug 14, 2023
1 check passed
@hakanson hakanson deleted the vite-app-updates branch October 19, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ottokruse ottokruse ottokruse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hakanson @ottokruse