Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add web compatibility #60

Merged
merged 81 commits into from
Mar 29, 2022
Merged

add web compatibility #60

merged 81 commits into from
Mar 29, 2022

Conversation

hakanson
Copy link
Contributor

@hakanson hakanson commented Mar 8, 2022

Issue #, if available:

Description of changes:

  • add web specific implementation and use subpath imports to choose implementation at runtime
  • web version uses webcrypto instead of node crypto to verify JWT and import keys
  • web version of fetch and added base64url decoding method
  • added tests using vite and cypress to test "in browser"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@leelalagudu leelalagudu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have nit picking comments, nothing blocker.

This is great stuff 🎉

README.md Outdated Show resolved Hide resolved
src/jwk.ts Outdated Show resolved Hide resolved
src/jwt-rsa.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
tests/unit/jwt-rsa.test.ts Show resolved Hide resolved
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work lets ship it 🎉

Thanks guys! @hakanson @ottokruse @leelalagudu

@hakanson hakanson merged commit c1a4479 into awslabs:main Mar 29, 2022
@hakanson hakanson deleted the web-compat-vite branch March 29, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants