Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: throw if AWS_REGION environment variable is missing #158

Merged
merged 1 commit into from Aug 22, 2022
Merged

tests: throw if AWS_REGION environment variable is missing #158

merged 1 commit into from Aug 22, 2022

Conversation

bmoffatt
Copy link
Collaborator

@bmoffatt bmoffatt commented Aug 21, 2022

Description of changes:

I spent way too long trying to figure out why the tests were hanging for minutes doing retries on my bare linux installation, but worked fine when run on AWS Code Build. Hopefully this helps my future self and other contributors.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bmoffatt bmoffatt marked this pull request as ready for review August 22, 2022 01:30
Copy link
Contributor

@marcomagdy marcomagdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmoffatt bmoffatt merged commit fab4a6e into awslabs:master Aug 22, 2022
@bmoffatt bmoffatt deleted the throw-it branch August 22, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants