Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for executing the AWS CodeBuild workflows locally #160

Merged
merged 2 commits into from Aug 23, 2022
Merged

Add instructions for executing the AWS CodeBuild workflows locally #160

merged 2 commits into from Aug 23, 2022

Conversation

bmoffatt
Copy link
Collaborator

Description of changes:

change separated out from #159

Added instructions to CONTRIBUTING.md for guidance on executing the CodeBuild testing locally based on https://docs.aws.amazon.com/codebuild/latest/userguide/use-codebuild-agent.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bmoffatt bmoffatt marked this pull request as ready for review August 22, 2022 20:58
Copy link
Contributor

@marcomagdy marcomagdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff.

## Running the Integration Tests Locally

The integration testing for the project creates, invokes, and deletes, Lambda functions.
These tests typically run AWS CodeBuild, but may also be executed locally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These tests typically run AWS CodeBuild, but may also be executed locally
These tests typically run on AWS CodeBuild, but may also be executed locally

So this literally runs CodeBuild locally using CodeBuild's docker image, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

then
docker_command+=" $local_agent_image"
else
docker_command+=" public.ecr.aws/codebuild/local-builds:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I love this script the codebuild folk wrote! My only complaint is that it doesn't auto detect aarch64, gotta pass in override image from their docs explicitly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants