Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS CodeBuild workflow and Dockerfile for ArchLinux #161

Merged
merged 6 commits into from Aug 23, 2022
Merged

Add AWS CodeBuild workflow and Dockerfile for ArchLinux #161

merged 6 commits into from Aug 23, 2022

Conversation

bmoffatt
Copy link
Collaborator

Description of changes:

This change was originally a part of #159

Adds CI support for ArchLinux ci/docker/arch-linux ci/codebuild/arch-linux.yml

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bmoffatt bmoffatt marked this pull request as ready for review August 22, 2022 20:58

RUN CC=/usr/bin/clang CXX=/usr/bin/clang++ cmake -Saws-sdk-cpp -Baws-sdk-cpp/build -GNinja \
-DBUILD_ONLY=lambda \
-DUSE_OPENSSL=OFF \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fun one - basically, because reasons (aws/aws-sdk-cpp#1910), including the current version of AWS SDK into the project (as the tests do) - CMake barfs at test time (./ci/codebuild/build.sh in arch-linux.yml) complaining about not being able to find openssl, enough though it was found just fine when doing the SDK build + install! For the other build environments we have, something like yum install -y openssl-static is resolving the dependency, but an equivalent package is not available (that I could find anyways) in this distro.

So... the workaround I've been doing is using the experimental S2N support in the SDK, triggered by this flag. This works fine, but also brought along the requirement to use clang instead of gcc due to differences in warnings/errors reported on when Came compiled with this distro's gcc/g++.

🤷‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes!
You should probably put that blurb of reasoning as a comment in the docker file.
I wish the C++ SDK never adopted the CRT. Oh Well!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a shorter version of this comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Arch linux, the AUR has a package openssl-static.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If desired, it could be installed with:

git clone --depth 1 https://aur.archlinux.org/openssl-static.git
cd openssl-static
makepkg -si --noconfirm --skippgpcheck

However, it will build openssl from source, which takes quite a while.

@bmoffatt bmoffatt merged commit ed43dbb into awslabs:master Aug 23, 2022
@bmoffatt bmoffatt deleted the arch-linux-ci branch August 23, 2022 07:59

# Note: (2022-08-23)
# Using -DUSE_OPENSSL=OFF as a workaround to an AWS SDK dependency issue with this distro.
# The current SDK version has a dependency on a static build version of openssl, not available through pacman.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not available as a built package from the main repositories. If you build openssl-static from the AUR with makepkg, the resulting package can be installed with pacman -U <package-file>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants