Re-write codebuild.yml and dockerfiles for consistency and code build execution speed #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… workflow structure, put more dependency build into the docker image, etc
|
current codebuild workflows configured expected to vomit on this PR as the .yml and docker images drifted - will be creating updated workflows representative of the new images, and re-trigger this PR with empty commits |
bmoffatt
commented
Aug 22, 2022
| @@ -1,10 +1,18 @@ | |||
| FROM amazonlinux:2017.03 | |||
| FROM public.ecr.aws/amazonlinux/amazonlinux:2018.03 | |||
There was a problem hiding this comment.
intentionally leaving the filename out of date with the base image right now to make my life a bit easier in the short term for managing the creation of the replacement CI workflows
why did the repo+tag change? - because I have automation in #159 to re-drives the docker builds from AWS CodeBuild, that DockerHub likes to throttle - however I could not find a :2017.03 tag in the public.ecr.aws gallery - so, next best thing is to use an actually updated tip tag for the original AmazonLinux
marcomagdy
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change was originally posted as a part of #159
Mostly did this to resolve constantly waiting for AWS SDK build, by moving the step out of any
ci/codebuild/*.ymland into the respectiveci/docker/*- to cache it for personal sanity.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.