Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building and packaging a demo project to CI and revert #136 #183

Merged
merged 5 commits into from Feb 27, 2023

Conversation

kkarbowiak
Copy link
Contributor

Issue #, if available: #182

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kkarbowiak kkarbowiak marked this pull request as ready for review January 19, 2023 14:27
@kkarbowiak
Copy link
Contributor Author

Thew newly added build-demo job fails, but my best guess is that this is related to #179. In any case, detecting such issues is the main reason for adding this job.

@marcomagdy
Copy link
Contributor

We're failing on some new clang-tidy checks.
The warnings are benign though. One of them is about variable name length (we should fix that) and the other is about easily swappable parameters. I am not supportive of making code changes to fix the latter.

@marcomagdy
Copy link
Contributor

Thanks for the PR btw. Good idea.

@bmoffatt
Copy link
Collaborator

Added the revert commit that makes the test pass, and updating title to match for future release notes

@bmoffatt bmoffatt changed the title Add building and packaging a demo project to CI Add building and packaging a demo project to CI and revert #136 Feb 27, 2023
@bmoffatt bmoffatt merged commit c09c86e into awslabs:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants