Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Lambda executable as the bootstrap when glibc is not required #191

Merged
merged 2 commits into from Nov 16, 2023

Conversation

marcomagdy
Copy link
Contributor

@marcomagdy marcomagdy commented Nov 15, 2023

This change decreases the cold-start times for functions developed on/for the same environment in which Lambda executes the binary.

When building the function on provided:al2 we don't need to package libc, and also we don't need the bootstrap bash script to start the executable.
Previously, at the time it was initially written, it was important to have LD_LIBRARY_PATH in the environment. But now Lambda environment already sets that for us.

In my own measurements, this takes cold-start time down by about 5ms, bringing it to equivalence with Rust.
See https://maxday.github.io/lambda-perf/

@marcomagdy marcomagdy marked this pull request as ready for review November 16, 2023 01:43
@marcomagdy
Copy link
Contributor Author

@bmoffatt and @Stefan9283 PTAL

Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmoffatt bmoffatt merged commit 934d254 into awslabs:master Nov 16, 2023
12 checks passed
@marcomagdy marcomagdy deleted the no-shell-script branch November 16, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants