Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not passing context.Context to http.Request context #27

Closed
snabb opened this issue Feb 7, 2019 · 0 comments
Closed

Not passing context.Context to http.Request context #27

snabb opened this issue Feb 7, 2019 · 0 comments

Comments

@snabb
Copy link
Contributor

snabb commented Feb 7, 2019

The package is not currently accepting context.Context parameter from the Lambda runtime. Therefore the downstream http.Request is lacking it also.

As a result the http handler can not observe the Deadline and is unable to cancel the request gracefully.

See:
https://docs.aws.amazon.com/lambda/latest/dg/go-programming-model-context.html
https://godoc.org/context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass context.Context from Lambda runtime to http.Request. snabb/aws-lambda-go-api-proxy
1 participant
@snabb