Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename Makefile target docs-dev to docs-local #65

Merged
merged 2 commits into from
Jun 7, 2020

Conversation

to-mc
Copy link
Contributor

@to-mc to-mc commented Jun 7, 2020

Issue #, if available:

Description of changes:

Makefile had 2 targets: docs-dev (which ran the gatsby docs site locally) and dev-docs (which installs required packages for docs build). Renamed the former to better represent what it does.

Breaking change checklist

Ignore if it's not a breaking change

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020

Codecov Report

Merging #65 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #65   +/-   ##
========================================
  Coverage    99.39%   99.39%           
========================================
  Files           15       15           
  Lines          492      492           
  Branches        44       44           
========================================
  Hits           489      489           
  Misses           3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f074de...bdf8a0b. Read the comment docs.

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Jun 7, 2020
Makefile Outdated Show resolved Hide resolved
@heitorlessa heitorlessa merged commit 158fd57 into develop Jun 7, 2020
@heitorlessa heitorlessa deleted the chore/rename_make_targets_docs branch June 7, 2020 13:48
heitorlessa added a commit that referenced this pull request Jun 7, 2020
* develop:
  improv: include example tests in `make tests` (#63)
  chore: rename Makefile target docs-dev to docs-local (#65)
  improv: better namespace/dimension handling for Metrics (#62)
heitorlessa added a commit that referenced this pull request Jun 10, 2020
* develop: (31 commits)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  improv: include example tests in `make tests` (#63)
  chore: rename Makefile target docs-dev to docs-local (#65)
  improv: better namespace/dimension handling for Metrics (#62)
  docs: build on master only
  chore: correct docstring for log_metrics
  chore: fix typo in metrics doc
  chore: Correct test comment
  chore: remove unused import
  chore: formatting
  feat: update Metrics interface to resemble tracer & logger: use "service" as its namespace.
  ...
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
* chore: rename docs-dev to docs-local

* improv: local api docs

Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants