Improved performance by instantiating and connecting to MQTT client… #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s only if it has any interested topic - Improved performance by disconnecting and removing MQTT clients that has no interested topic
rohandubal
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all
subscriptionInfoprovided by a subscription call instantiates and connects a MQTT client, even if it has no interested topic. And the opposite happens on unsubscribe call, not removing and cleaning unnecessary MQTT clients.Description of changes:
MQTTClientif there is any topic that theAppSyncMQTTClientis interested at.MQTTClientwithout interested topic. Disconnecting and removing it.