Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt to appsync client v3 #558

Closed
wants to merge 1 commit into from
Closed

fix: adapt to appsync client v3 #558

wants to merge 1 commit into from

Conversation

5d
Copy link
Contributor

@5d 5d commented Jan 24, 2023

Issue #, if available:

Description of changes:

  • adapting dependency appsync client v3 APIs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@5d 5d changed the title chore: adapt to appsync client v3 feat: adapt to appsync client v3 Jan 24, 2023
Copy link
Member

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying this out, looks like it's going to be pretty minimal changes. Let's run the integration tests as well, they should be passing but might not be compiling at first as there might be some test code updates needed.

From the prespective of the developer using AppSync SDK, I think even though the dependency is using AppSyncRT v3, this update can still be a patch update considering the V3 behavior hasn't changed. we can rename "feat" to "fix: adapt to appsync client v3" or "chore: adapt to appsync client v3", since "feat" should indicate a minor or major version bump

@5d
Copy link
Contributor Author

5d commented Jan 24, 2023

Sure, I will do the integration test and change it to a fix commit.

@5d 5d changed the title feat: adapt to appsync client v3 fix: adapt to appsync client v3 Jan 25, 2023
@5d
Copy link
Contributor Author

5d commented Jan 25, 2023

Verified all integration test cases are passed.
Screen Shot 2023-01-24 at 18 34 54

@5d
Copy link
Contributor Author

5d commented Feb 14, 2023

closing this PR as #561 has the similar changes and merged

@5d 5d closed this Feb 14, 2023
@5d 5d deleted the 5d/appsync-client-v3 branch February 14, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants