Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for observer being null #735

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

simon-q
Copy link
Contributor

@simon-q simon-q commented Oct 27, 2022

Issue #, if available:
#688

Description of changes:
Code does not check whether observer is null or undefined which sometimes happen.
I added a check similar to the checks being done earlier in the same function.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 thanks for the PR, @simon-q!

@dpilch dpilch merged commit db8f9ae into awslabs:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants