Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow adding of links and own cache #92

Closed
wants to merge 1 commit into from

Conversation

M1chaelTran
Copy link

rather than going down the path of replacing out the links like in #62
we wanted to keep the benefits but enable adding more user define links (eg. apollo-link-state)

for the cache, it can't help as we have to replace.

@zjullion
Copy link

Would love to see this merged - as it stands, without the ability to add custom links to the ApolloClient, it's impossible to catch errors from bad credentials (the app just crashes).

It's worth noting that there probably needs to be a slight change to this PR so that if links isn't passed in to the constructor, things still work:
if (!links) { links = [] } or something similar...

@manueliglesias
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants