Further updates to DBeaver integration docs #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
reviewed
Aug 29, 2022
| @@ -158,9 +158,15 @@ URL Template: jdbc:mysql:aws://{host}:{port} | |||
| </dependency> | |||
| ``` | |||
|
|
|||
| 4. DBeaver will respond: `Artifacts Found: 1`. | |||
| 4. Under advanced paramaters set | |||
There was a problem hiding this comment.
Suggested change
| 4. Under advanced paramaters set | |
| 4. Edit the following queries under `Advanced parameters` tab. These custom queries help DBeaver to enable database selector in UI. This setting is optional. |
sergiyvamz
reviewed
Aug 29, 2022
| @@ -158,9 +158,15 @@ URL Template: jdbc:mysql:aws://{host}:{port} | |||
| </dependency> | |||
| ``` | |||
|
|
|||
| 4. DBeaver will respond: `Artifacts Found: 1`. | |||
| 4. Under advanced paramaters set | |||
There was a problem hiding this comment.
I'd suggest to move this step after step 5.
|
Hi @tomchiverton, we have taken your changes and applied the feedback from @sergiyvamz in #379. We will be closing this PR now. Thank you for helping us improve the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #261