Fix - updating topology and connection switching to not use stale data #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchung-bitquill
changed the title
sergiyvamz
approved these changes
Jan 17, 2023
…connect switch code to not use stale topology info clean up test/debug code and comments
aaronchung-bitquill
force-pushed
the
rds-1240
branch
from
061812a
to
cb80770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses some issues regarding using stale topology and connecting switching
Description
Changed the criteria for updateTopologyAndConnectIfNeeded() and shouldExceptionTriggerConnectionSwitch() to not rely on isFailoverEnabled() since it may be using a stale host list.
Additional Reviewers
@sergiyv-improving @karenc-bq