Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for AWS CodeCommit as a source code provider. #14

Merged
merged 10 commits into from
Oct 25, 2019
Merged

Support for AWS CodeCommit as a source code provider. #14

merged 10 commits into from
Oct 25, 2019

Conversation

ferdingler
Copy link
Member

Description of changes:
Support for AWS CodeCommit as a source code provider for the pipeline. I have also updated the README file to include CodeCommit instructions. In the process I decided to turn the parameters section into a Table for better readability, instead of a numbered list. But it's just a proposal, I can change it back to a list if you prefer.

Testing
I have tested both workflows GitHub and CodeCommit work properly by launching 2 stacks in my AWS account, one for each.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@honglu
Copy link
Contributor

honglu commented Oct 22, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

honglu
honglu approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@honglu honglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

carvantes
carvantes reviewed Oct 22, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ferdingler @carvantes
Make SourceCodeProvider Optional as it defaults to GitHub
2259203 
Co-Authored-By: Nestor Carvantes <carvantes@gmail.com>
@honglu
Copy link
Contributor

honglu commented Oct 22, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ferdingler
Copy link
Member Author

Thanks for approving! Support for CodeCommit is going to make the pipeline very useful for my usecase!

jlhood
jlhood requested changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate this contribution! I think there are issues with the current state of required vs optional parameters. However, I'm excited for this app to be able to support more source repositories than just GitHub.

sam/app/template.yaml Show resolved Hide resolved
@honglu
Copy link
Contributor

honglu commented Oct 22, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jlhood
jlhood requested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is looking much better. A few minor callouts and then this should be good to go!

sam/app/template.yaml Outdated Show resolved Hide resolved
sam/app/template.yaml Show resolved Hide resolved
README.md Show resolved Hide resolved
@jlhood
Copy link
Contributor

jlhood commented Oct 23, 2019

@ferdingler Does it make sense to make a similar change to this app too?

https://github.com/awslabs/aws-sam-codebuild-ci

@honglu
Copy link
Contributor

honglu commented Oct 23, 2019

@ferdingler Does it make sense to make a similar change to this app too?

https://github.com/awslabs/aws-sam-codebuild-ci

Does it benefit a lot from a CodeCommit source? I think the biggest value the CI app provides is a badge and the github build logs.

@honglu
Copy link
Contributor

honglu commented Oct 24, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@honglu
Copy link
Contributor

honglu commented Oct 25, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jlhood
jlhood reviewed Oct 25, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@honglu
Copy link
Contributor

honglu commented Oct 25, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jlhood jlhood merged commit 43d25f3 into awslabs:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honglu honglu honglu approved these changes

@jlhood jlhood jlhood approved these changes

@carvantes carvantes carvantes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ferdingler @honglu @jlhood @carvantes