refactor: split AWS SDK specific customizations into new module #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
force-pushed
the
refactor-aws-protocols
branch
from
302fd16
to
2f84228
Compare
|
A new generated diff is ready to view. |
lauzadis
approved these changes
Dec 13, 2023
Comment on lines
-114
to
-123
| publishing { | ||
| publications { | ||
| create<MavenPublication>("codegen") { | ||
| from(components["java"]) | ||
| artifact(sourcesJar) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| configurePublishing("aws-sdk-kotlin") |
There was a problem hiding this comment.
question: does this no longer need to be published?
There was a problem hiding this comment.
We never should have published it in first place, we will publish it when we move it over to smithy-kotlin though.
ianbotsf
approved these changes
Dec 13, 2023
|
A new generated diff is ready to view. |
aajtodd
added
the
no-changelog
aajtodd
force-pushed
the
refactor-aws-protocols
branch
from
d2da06a
to
0eeedf3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
upstream: smithy-lang/smithy-kotlin#1012
Description of changes
This PR is a first step to separating AWS protocol support from AWS SDK specific customizations. Specifically we introduce a new module
aws-sdk-codegenwhich is everything AWS SDK for Kotlin specific. The existingsmithy-aws-kotlin-codegennow only contains AWS protocol support.refactor: Split out AWS SDK for Kotlin specific customizations into a new module
aws-sdk-codegenrefactor: Use the
software.amazon.smithy.kotlin.codegen.awsnamespace for AWS protocol support instead ofaws.sdk.kotlin.codegento better align with the rest of the code generation insmithy-kotlinrefactor: Remove
S3Generatorin favor of overriding sectionsfix: Fix route53 customization to only apply to the operation it is meant to
refactor: Migrate flow utils to
smithy-kotlinruntime.Follow up work
The line between "AWS SDK" and "AWS Protocol" isn't super well defined. We may find I got some of this wrong and need to move things around a bit more 🤷♂️.
smithy-kotlinsmithy-kotlinBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.