Skip to content

Commit

Permalink
[smithy-rs] Add crate versions in CHANGELOG (#2348)
Browse files Browse the repository at this point in the history
* Move rendering external contributors to a function

This commit moves the code for rendering external contributors to its own
function, in line with other render_* functions.

* Add type alias `CrateVersionMetadataMap`

This commit adds a type alias `CrateVersionMetadataMap` for a field in
`VersionsManifest`. In a subsequent commit, the `changelogger` crate
will refer to this field, and it's better for that crate to not use the
field's bare type `BTreeMap<String, CrateVersion>`.

* Render crate versions in CHANGELOG

This commit addresses a pain point brought up in #731.
A binary `changelogger` now has a new command line option
`--current-release-versions-manifest` that points to the latest
`versions.toml` in the `aws-sdk-rust` repository. The program
will generate a markdown table showing crate versions from that
manifest and include it in an expand/collapse section.

* Add a leading pipe when rendering markdown table

This commit addresses smithy-lang/smithy-rs#2348 (comment)

---------

Co-authored-by: Yuki Saito <awsaito@amazon.com>
Co-authored-by: Zelda Hessler <zhessler@amazon.com>
  • Loading branch information
3 people authored and aws-sdk-rust-ci committed Mar 30, 2023
1 parent 4141cd3 commit 6bffb09
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 29 deletions.
8 changes: 4 additions & 4 deletions sdk/kinesis/src/input.rs
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ impl DeregisterStreamConsumerInput {
.set_endpoint(_config.endpoint_url
.clone())
.set_operation_type(Some("control".to_string()))
.set_consumer_arn(self.consumer_arn.clone())
.set_stream_arn(self.stream_arn.clone()).build()
.set_stream_arn(self.stream_arn.clone())
.set_consumer_arn(self.consumer_arn.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -559,8 +559,8 @@ impl DescribeStreamConsumerInput {
.set_endpoint(_config.endpoint_url
.clone())
.set_operation_type(Some("control".to_string()))
.set_consumer_arn(self.consumer_arn.clone())
.set_stream_arn(self.stream_arn.clone()).build()
.set_stream_arn(self.stream_arn.clone())
.set_consumer_arn(self.consumer_arn.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down
44 changes: 22 additions & 22 deletions sdk/s3control/src/input.rs
Original file line number Diff line number Diff line change
Expand Up @@ -606,8 +606,8 @@ impl DeleteAccessPointPolicyInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_account_id(self.account_id.clone())
.set_access_point_name(self.name.clone()).build()
.set_access_point_name(self.name.clone())
.set_account_id(self.account_id.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -1895,8 +1895,8 @@ impl GetAccessPointPolicyInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_access_point_name(self.name.clone())
.set_account_id(self.account_id.clone()).build()
.set_account_id(self.account_id.clone())
.set_access_point_name(self.name.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -2054,8 +2054,8 @@ impl GetAccessPointPolicyStatusInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_account_id(self.account_id.clone())
.set_access_point_name(self.name.clone()).build()
.set_access_point_name(self.name.clone())
.set_account_id(self.account_id.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -2213,8 +2213,8 @@ impl GetBucketInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_account_id(self.account_id.clone())
.set_bucket(self.bucket.clone()).build()
.set_bucket(self.bucket.clone())
.set_account_id(self.account_id.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -2373,8 +2373,8 @@ impl GetBucketPolicyInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_account_id(self.account_id.clone())
.set_bucket(self.bucket.clone()).build()
.set_bucket(self.bucket.clone())
.set_account_id(self.account_id.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -3284,8 +3284,8 @@ impl ListAccessPointsInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_account_id(self.account_id.clone())
.set_bucket(self.bucket.clone()).build()
.set_bucket(self.bucket.clone())
.set_account_id(self.account_id.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -3655,8 +3655,8 @@ impl ListRegionalBucketsInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_account_id(self.account_id.clone())
.set_outpost_id(self.outpost_id.clone()).build()
.set_outpost_id(self.outpost_id.clone())
.set_account_id(self.account_id.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -3908,8 +3908,8 @@ impl PutAccessPointPolicyInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_access_point_name(self.name.clone())
.set_account_id(self.account_id.clone()).build()
.set_account_id(self.account_id.clone())
.set_access_point_name(self.name.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -4075,8 +4075,8 @@ impl PutBucketLifecycleConfigurationInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_account_id(self.account_id.clone())
.set_bucket(self.bucket.clone()).build()
.set_bucket(self.bucket.clone())
.set_account_id(self.account_id.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -4171,8 +4171,8 @@ impl PutBucketPolicyInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_account_id(self.account_id.clone())
.set_bucket(self.bucket.clone()).build()
.set_bucket(self.bucket.clone())
.set_account_id(self.account_id.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down Expand Up @@ -4267,8 +4267,8 @@ impl PutBucketTaggingInput {
.clone())
.set_use_arn_region(_config.use_arn_region)
.set_requires_account_id(Some(true))
.set_bucket(self.bucket.clone())
.set_account_id(self.account_id.clone()).build()
.set_account_id(self.account_id.clone())
.set_bucket(self.bucket.clone()).build()
.map_err(|err|aws_smithy_http::endpoint::ResolveEndpointError::from_source("could not construct endpoint parameters", err));
let (endpoint_result, params) = match params_result {
Ok(params) => (_config.endpoint_resolver.resolve_endpoint(&params), Some(params)),
Expand Down
6 changes: 3 additions & 3 deletions versions.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
smithy_rs_revision = '5183ccbd6c8874a7379f5f535762b4fddbc49478'
smithy_rs_revision = 'dbafd684710a29a4f2a1840a2adf588df9ad0beb'
aws_doc_sdk_examples_revision = '97a177aab8c3d2fef97416cb66e4b4d0da840138'

[manual_interventions]
Expand Down Expand Up @@ -1057,7 +1057,7 @@ model_hash = '9ec8a92782fbef7e2cf07fc9b5e656aa37b59668baff33acae10f270cfff4193'
[crates.aws-sdk-kinesis]
category = 'AwsSdk'
version = '0.25.0'
source_hash = '325793b25c5ea997207a938da73195aa8f4a50ad977c1cb022e06aaaee2ea6e2'
source_hash = '4045691365de44d9d185df927765804581b2acd2b4c1ad2efdca8afe418f3c3b'
model_hash = '5eaef8321cea414140d87258e714988d88f3e41d9cdf4b83a1417027cb702cb9'

[crates.aws-sdk-kinesisanalytics]
Expand Down Expand Up @@ -1669,7 +1669,7 @@ model_hash = 'fb47cfd49cf2d9250063914599f703ed365b51be373988dc3f2cd64321c9583b'
[crates.aws-sdk-s3control]
category = 'AwsSdk'
version = '0.25.0'
source_hash = '6eae47fba0547946e015464ca2e4a900c866150269e228a357fc7b8130694ee8'
source_hash = 'ce595c64dc66bcb505315398eb41e4045a2c9594e95b17e20f1a06fea120a469'
model_hash = '930bd33c05c393293591ae01cbdb6637fb5062ed3a3ad5e2dadddd8108cc8478'

[crates.aws-sdk-s3outposts]
Expand Down

0 comments on commit 6bffb09

Please sign in to comment.