-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[request] Allow overriding of request configuration on fluent request builders #537
Comments
Thanks for submitting this, I have an idea of how to support this and I'll run it by the team to see what they think. |
@jszwedko The way to accomplish this task today is to:
That's obviously not a very friendly experience. The much nicer solution would require adding a new API to allow converting a fluent builder into some type @rcoh imagines the UX looking like this: let sendable = dynamodb.list_tables().limit(5).<workshop work here>();
sendable.map_operation(|op| op.augment(...).send().await; We'd need an RFC proposal covering all this before moving forward with a PR. I'm currently absorbed in checksum work relating to S3 but I may be able to look at this afterwards. I can't give any time estimate or guarantee though. If you're interested in writing and submitting an RFC for this, we can coach you on the process. Let me know if that's how you'd like to proceed. |
Thanks for the response @Velfi ! I missed that the request could be split into parts and reconstructed. We can give that a shot. Otherwise that UI you mentioned looks decent to me to be able to compose the operations similar to what the Java SDK allows for. |
I have a PR implementing John's RFC that should make things much nicer. |
It is now possible with the latest SDK to add this header. Take a look at the notes for release-2022-09-21 for an example. |
|
Describe the feature
Hi all!
We have a feature request on vector to allow setting the
x-amzn-logs-format
HTTP header tojson/emf
when publishing events to CloudWatch Logs viaPutLogEvents
to send embedded metrics.I found an example of doing it with the Java SDK:
But I don't see a similar sort of method for overriding request headers for the Rust SDK. Am I missing something? Or would this be a feature request?
Use Case
Overriding request headers on a per API call-basis.
Proposed Solution
Add a method to all fluent builders that allows overriding request configuration including headers.
Here is what the Java SDK seems to support overriding:
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/core/RequestOverrideConfiguration.html
Other Information
No response
Acknowledgements
A note for the community
Community Note
The text was updated successfully, but these errors were encountered: