Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Ability to specify creds at the request level #696

Closed
2 tasks
DanielBauman88 opened this issue Dec 26, 2022 · 3 comments
Closed
2 tasks

[request] Ability to specify creds at the request level #696

DanielBauman88 opened this issue Dec 26, 2022 · 3 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@DanielBauman88
Copy link
Contributor

DanielBauman88 commented Dec 26, 2022

Describe the feature

Currently the AWS SDKs do not allow for creds to be specified at the request level, only at the client level.

Use Case

There are many valid use-cases where a web service might want to make requests with different creds. A good example is a web service interacting with customer resources. Amazon recommends a pattern where the web service can use creds to isolate permissions to resources owned by the customer making the call (talk, iam feature helping with federated creds).

The SDK clients handle tcp connection pooling which provides better performance and fewer higher-percentile spikes than you get if you create a new client and new TCP connections on every call.

Proposed Solution

It would be a benefit to SDK customers to support this use-case in the SDK by providing a mechanism to override the creds provider on a per-request basis so that customers using a federated connection model aren't hurt by needing to create a new sdk each time they want to change creds.

Other Information

I'm asking this question in the aws-sdk-rust repo because the SDK I want this for is Rust, but this applies to the AWS SDKs more generally. As far as I know no sdk in any language supports a documented interface for this, but it can be achieved in some languages with looser controls like javascript.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@DanielBauman88 DanielBauman88 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 26, 2022
@Velfi Velfi removed the needs-triage This issue or PR still needs to be triaged. label Dec 27, 2022
@Velfi
Copy link
Contributor

Velfi commented Dec 27, 2022

Hey @DanielBauman88, thanks for submitting this issue. We'll add it to our backlog.

@jmklix Can you follow up on whether we should add a copy of this issue to the cross-SDK issues repo?

@Velfi Velfi added the p2 This is a standard priority issue label Dec 27, 2022
@rcoh
Copy link
Contributor

rcoh commented Apr 24, 2024

This is complete—You can use config_override to specify per-request credentials

@rcoh rcoh closed this as completed Apr 24, 2024
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants