Update canary action for S3 Express + Wasm #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets `ENABLE_S3_EXPRESS_CANARY` to true so that S3 Express canary starts running in `aws-sdk-rust` repo. Note that we run canary against three releases; latest, previous, and the one before last. This env variable is temporary, and we were originally going to turn it on after S3 Express implementation is available in those releases (which should be after 2024-03-15), otherwise s3_express_canary would fail. However, since the canary already fails due to `canary-wasm` not being able to find `aws-smithy-wasm` in `versions.toml`, so setting the said env variable right now will not make things worse. `canary-wasm` should start passing when run against 2024-03-15, 2024-03-14, and 2024-03-13, and so should s3_express_canary. At that point, we can remove `ENABLE_S3_EXPRESS_CANARY` and run s3_express_canary by default.
ysaito1001
changed the title
Velfi
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix issue where canary fails at runtime because the S3 express bucket was unset.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.