Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError: cannot import name 'loaders' on startup #25

Closed
donnemartin opened this issue Dec 5, 2015 · 3 comments
Closed

ImportError: cannot import name 'loaders' on startup #25

donnemartin opened this issue Dec 5, 2015 · 3 comments

Comments

@donnemartin
Copy link
Collaborator

@jamesls I don't see the loaders module included in f709ba0, seems to be causing this issue:

$ aws-shell
Traceback (most recent call last):
  File "/Users/donnemartin/.virtualenvs/aws-shell3/bin/aws-shell", line 9, in <module>
    load_entry_point('aws-shell==0.0.1', 'console_scripts', 'aws-shell')()
  File "/Users/donnemartin/.virtualenvs/aws-shell3/lib/python3.4/site-packages/pkg_resources/__init__.py", line 558, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/Users/donnemartin/.virtualenvs/aws-shell3/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2682, in load_entry_point
    return ep.load()
  File "/Users/donnemartin/.virtualenvs/aws-shell3/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2355, in load
    return self.resolve()
  File "/Users/donnemartin/.virtualenvs/aws-shell3/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2361, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/Users/donnemartin/Dev/github/forks/aws-shell/awsshell/__init__.py", line 12, in <module>
    from awsshell import loaders
ImportError: cannot import name 'loaders'
@jamesls
Copy link
Member

jamesls commented Dec 7, 2015

Ah good catch, I'll update this.

@jamesls jamesls closed this as completed in e71cf35 Dec 7, 2015
@donnemartin
Copy link
Collaborator Author

Thanks for the fix James. I can hook up a pexpect unit test to catch related errors. Here's an example of what I'm thinking:

https://github.com/donnemartin/saws/blob/master/tests/test_cli.py

Note pexpect doesn't run on Windows, but that's probably fine since we're probably going to be running on Travis. If we use something like AppVeyor we'd need to hook up something like WExpect.

@jamesls
Copy link
Member

jamesls commented Dec 8, 2015

I'd ideally like to find an approach that works on both linux/windows without much trouble. I don't remember if it was WExpect that I've used before, but I do remember running problems getting any kind of expect-like python library working on windows.

I think the issue right now is I can't hook this up to travis CI until this goes public so I don't have the usual travis CI checks I'm use to. I'm hoping this problem goes away shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants