Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the AWSCLIModelCompleter attribute from AWSShell. #66

Open
donnemartin opened this issue Dec 17, 2015 · 0 comments
Open

Remove the AWSCLIModelCompleter attribute from AWSShell. #66

donnemartin opened this issue Dec 17, 2015 · 0 comments
Assignees
Milestone

Comments

@donnemartin
Copy link
Collaborator

Original discussion: https://github.com/awslabs/aws-shell/pull/45/files#diff-d0a45db8e5ed54b02374996d81926a8cR65

The model completer is also available via the .completer property on shellcomplete.AWSShellCompleter. I think I still have some refactoring to do to get all the various autocompleters more coherent.

My line of thinking was that the ShellCompleter is the only thing the app needs to interact with for anything completion related, and the ShellCompleter can proxy to the model completer and server side completer as needed. I don't think I have the abstractions 100% right yet, but ideally I'd like to be able to just say completer.match_fuzzy and then internally, the ShellCompleter can set the match_fuzzy attribute on the model completer.

We don't have to do this now, but I think it would simplify things by not requiring the AWSShell class to take in an additional param in its init.

@jamesls jamesls added this to the 0.1.0 milestone Dec 29, 2015
@jamesls jamesls self-assigned this Dec 29, 2015
@jamesls jamesls modified the milestones: 0.2.0, 0.1.0 Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants