Fix most of the unit tests #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcode `x86_64` architecture for these calls in unit tests
snay2
commented
Jun 13, 2022
| @@ -56,7 +56,7 @@ func TestGetTagAsFilter(t *testing.T) { | |||
| actualTagFilter, err := tag.GetTagAsFilter(*tags) | |||
| now := time.Now() | |||
| zone, _ := now.Zone() | |||
| currTimeStr := fmt.Sprintf("%d-%d-%d %d:%d:%d %s", now.Year(), now.Month(), now.Day(), now.Hour(), now.Minute(), | |||
| currTimeStr := fmt.Sprintf("%04d-%02d-%02d %02d:%02d:%02d %s", now.Year(), now.Month(), now.Day(), now.Hour(), now.Minute(), | |||
There was a problem hiding this comment.
@GavinBurris42 This one I copied over directly from your fork https://github.com/GavinBurris42/aws-simple-ec2-cli/pull/1/files so we can get it into main faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
After several recent changes, the unit tests broke, but since we don't run them automatically on PRs via GitHub Actions, it took a while for us to notice. I intend to get the tests running on PRs in the future, but getting them passing again locally is the first step.
Here are the tests I fixed (they're each broken into a separate commit if you want to review individually):
The only one unit test that isn't passing after this is
TestAskQuestion_AnyStringAnswer(), even though it seems correct.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.