Skip to content

Commit

Permalink
fix(aws-lambda-ssm-string-parameter): Code review fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
danielmatuki committed May 19, 2021
1 parent 852a225 commit 4093afe
Show file tree
Hide file tree
Showing 30 changed files with 208 additions and 465 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ test("Test minimal deployment with an existing VPC", () => {
});

// --------------------------------------------------------------
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPCs
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPC
//
// buildLambdaFunction should throw an error if the Lambda function is not
// attached to a VPC
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ test("Test minimal deployment with an existing VPC", () => {
});

// --------------------------------------------------------------
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPCs
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPC
//
// buildLambdaFunction should throw an error if the Lambda function is not
// attached to a VPC
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,18 +99,18 @@ test('Test deployment w/ existing function', () => {
handler: 'index.handler',
code: lambda.Code.fromAsset(`${__dirname}/lambda`)
};
const existingFuntion = defaults.deployLambdaFunction(stack, lambdaFunctionProps);
const existingFunction = defaults.deployLambdaFunction(stack, lambdaFunctionProps);

const pattern = new LambdaToSecretsmanager(stack, 'lambda-to-secretsmanager-stack', {
existingLambdaObj: existingFuntion,
existingLambdaObj: existingFunction,
secretProps: { removalPolicy: RemovalPolicy.DESTROY },
});
// Assertion 1
expect(stack).toHaveResource("AWS::SecretsManager::Secret", {
GenerateSecretString: {},
});
// Assertion 2
expect(pattern.lambdaFunction).toBe(existingFuntion);
expect(pattern.lambdaFunction).toBe(existingFunction);
});

// --------------------------------------------------------------
Expand Down Expand Up @@ -291,7 +291,7 @@ test("Test minimal deployment with an existing VPC", () => {
});

// --------------------------------------------------------------
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPCs
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPC
//
// buildLambdaFunction should throw an error if the Lambda function is not
// attached to a VPC
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ test("Test minimal deployment with an existing VPC", () => {
});

// --------------------------------------------------------------
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPCs
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPC
//
// buildLambdaFunction should throw an error if the Lambda function is not
// attached to a VPC
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ test("Test minimal deployment with an existing VPC", () => {
});

// --------------------------------------------------------------
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPCs
// Test minimal deployment with an existing VPC and existing Lambda function not in a VPC
//
// buildLambdaFunction should throw an error if the Lambda function is not
// attached to a VPC
Expand Down

This file was deleted.

This file was deleted.

Loading

0 comments on commit 4093afe

Please sign in to comment.